chore: add ifdefs for DEBUGGER, cleanup

src/cia.cpp

@@ -1182,7 +1182,6 @@ static bool keymcu_execute(void)
 	bool handshake = (cia[0].t[0].cr & 0x40) != 0 && (cia[0].sdr_buf & 0x80) == 0;
 
 #if 1
-	extern int blop;
 	if (blop & 1) {
 		handshake = true;
 	}

src/dsp3210/DSP3210_emulation.cpp

@@ -6,7 +6,9 @@
 #include "DSP3210_emulation.h"
 
 extern void write_log(const char *, ...);
+#ifdef DEBUGGER
 extern void activate_debugger(void);
+#endif
 
 /* Typedefs */
 typedef union 

src/fpp.cpp

@@ -13,9 +13,8 @@
 #define FPU_TEST 0
 #define FPU_LOG 0
 
-#include <math.h>
-#include <float.h>
-#include <fenv.h>
+#include <cmath>
+#include <cfloat>
 
 #include "sysconfig.h"
 #include "sysdeps.h"

src/fpp_native.cpp

@@ -692,12 +692,16 @@ static void fp_int(fpdata *a, fpdata *b)
     {
         case FPCR_ROUND_NEAR:
             a->fp = fp_round_to_nearest(bb);
+            break;
         case FPCR_ROUND_ZERO:
             a->fp = fp_round_to_zero(bb);
+            break;
         case FPCR_ROUND_MINF:
             a->fp = fp_round_to_minus_infinity(bb);
+            break;
         case FPCR_ROUND_PINF:
             a->fp = fp_round_to_plus_infinity(bb);
+            break;
         default: /* never reached */
 		break;
     }
@@ -1150,10 +1154,8 @@ static void fp_from_pack (fpdata *src, uae_u32 *wrd, int kfactor)
 		ndigits = kfactor;
 	}
 
-	if (ndigits < 0)
-		ndigits = 0;
-	if (ndigits > 16)
-		ndigits = 16;
+	ndigits = std::max(ndigits, 0);
+	ndigits = std::min(ndigits, 16);
 
 	// remove decimal point
 	strp[1] = strp[0];

src/include/fpp.h

@@ -7,6 +7,7 @@
 /* E = MAX & F # 0 -> NotANumber */
 /* E = biased by 127 (single) ,1023 (double) ,16383 (extended) */
 
+#pragma once
 #define FPSR_BSUN       0x00008000
 #define FPSR_SNAN       0x00004000
 #define FPSR_OPERR      0x00002000

src/inputrecord.cpp

@@ -55,7 +55,9 @@ static uae_u32 cycleoffset;
 
 static uae_u32 pcs[16];
 static uae_u64 pcs2[16];
+#ifdef DEBUGGER
 extern void activate_debugger (void);
+#endif
 static int warned;
 
 static void setlasthsync (void)
@@ -689,7 +691,6 @@ void inprec_recorddebug (uae_u32 val)
 void inprec_playdebug (uae_u32 val)
 {
 #if INPUTRECORD_DEBUG > 0
-	extern void activate_debugger (void);
 	static uae_u32 pcs[16];
 	int err = 0;
 	if (inprec_pstart (INPREC_DEBUG)) {

src/machdep/m68k.h

@@ -55,8 +55,8 @@ struct flag_struct {
 	uint64 cznv;
 	uint64 x;
 #else
-    uint32 cznv;
-    uint32 x;
+	uint32 cznv;
+	uint32 x;
 #endif
 };
 

src/mame/mameglue.h

@@ -6,7 +6,9 @@
 #define LSB_FIRST
 
 extern void write_log(const char *, ...);
+#ifdef DEBUGGER
 extern void activate_debugger(void);
+#endif
 
 #define MIN(a, b) ((a) > (b) ? (a) : (b))
 

src/osdep/amiberry.cpp

@@ -1840,7 +1840,7 @@ bool handle_events()
 		{
 			setpaused(pause_emulation);
 			was_paused = pause_emulation;
-			gui_fps(0, 0, 0, 0, 0);
+			gui_fps(0, 0, false, 0, 0);
 			gui_led(LED_SND, 0, -1);
 			// we got just paused, report it to caller.
 			return true;

src/osdep/amiberry_whdbooter.cpp

@@ -1367,8 +1367,8 @@ void whdload_auto_prefs(uae_prefs* prefs, const char* filepath)
 		// SET THE BASE AMIGA (Expanded A1200)
 		write_log("WHDBooter - Host: A1200 ROM selected\n");
 		built_in_prefs(prefs, 4, A1200_CONFIG, 0, 0);
-        // set 8MB Fast RAM
-        prefs->fastmem[0].size = 0x800000;
+		// set 8MB Fast RAM
+		prefs->fastmem[0].size = 0x800000;
 		_tcscpy(prefs->description, _T("AutoBoot Configuration [WHDLoad] [AGA]"));
 	}
 	else

src/pcem/pcemglue.cpp

@@ -93,8 +93,9 @@ void pclog(char const *format, ...)
 	write_log("%s", buf);
 	va_end(parms);
 }
-
+#ifdef DEBUGGER
 extern void activate_debugger(void);
+#endif
 void fatal(char const *format, ...)
 {
 	va_list parms;
@@ -103,7 +104,9 @@ void fatal(char const *format, ...)
 	vsnprintf(buf, sizeof buf, format, parms);
 	write_log("PCEMFATAL: %s", buf);
 	va_end(parms);
+#ifdef DEBUGGER
 	activate_debugger();
+#endif
 }
 
 void video_updatetiming(void)

src/pcem/vid_inmos.cpp

@@ -15,7 +15,9 @@
 #include "vid_svga_render.h"
 #include "vid_sdac_ramdac.h"
 
+#ifdef DEBUGGER
 extern void activate_debugger(void);
+#endif
 
 enum
 {

src/pcem/vid_permedia2.cpp

@@ -81,7 +81,9 @@ Not emulated and Someone Else's Problem:
 #define REG_FBSOURCEDELTA		0x0d88
 #define REG_CONFIG				0x0d90
 
+#ifdef DEBUGGER
 extern void activate_debugger(void);
+#endif
 
 typedef struct permedia2_t
 {

src/ppc/ppc.cpp

@@ -400,7 +400,9 @@ static void map_banks(void)
 
 	PPCMemoryRegion regions[UAE_MEMORY_REGIONS_MAX];
 	UaeMemoryMap map;
+#ifdef DEBUGGER
 	uae_memory_map(&map);
+#endif
 
 	for (int i = 0; i < map.num_regions; i++) {
 		UaeMemoryRegion *r = &map.regions[i];

src/qemuvga/qemuuaeglue.h

@@ -5,7 +5,9 @@
 #include <string.h>
 #include "sysconfig.h"
 
+#ifdef DEBUGGER
 extern void activate_debugger(void);
+#endif
 
 //#define DEBUG_VGA_REG
 //#define DEBUG_VGA