LIV2/WinUAE
1
0
Fork 0
mirror of https://github.com/LIV2/WinUAE.git synced 2025-12-06 00:12:52 +00:00
Code Issues Packages Projects Releases Wiki Activity

Avoid using isspace() with signed characters

Browse Source 
"char" is signed by default on many systems, so when using a "char"
variable as input to isspace(), which takes an "int" parameter, the
parameter gets sign-extended. Now in some libc implementations, the
isspace() function is implemented as a macro that directly indexes
an array for looking up the result - which might go wrong, of course,
if the byte values has the highest bit set. So when compiling Hatari
with Cygwin, there are the following compiler warnings:

.../build68k.c: In function ‘main’:
.../build68k.c:314:18: warning: array subscript has type ‘char’ [-Wchar-subscripts]
  314 |   while (isspace(*opstrp))
      |                  ^~~~~~~
.../build68k.c:319:18: warning: array subscript has type ‘char’ [-Wchar-subscripts]
  319 |    if (!isspace (*osendp))
      |                  ^~~~~~~
.../build68k.c:331:19: warning: array subscript has type ‘char’ [-Wchar-subscripts]
  331 |   while (!isspace(*p++));
      |                   ^~~~

Thus let's make sure to cast the "char" to unsigned first before using
it as parameter to the isspace() function.
This commit is contained in:
Thomas Huth 2020-10-06 04:44:57 +02:00
parent 2ea70e6bc1
commit 46bef05131
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
build68k.cpp
View File

@ -311,12 +311,12 @@ int main(int argc, char **argv)
char tmp[100], *p; char tmp[100], *p;
int slen = 0; int slen = 0;
while (isspace(*opstrp)) while (isspace((unsigned char)*opstrp))
opstrp++; opstrp++;
osendp = opstrp; osendp = opstrp;
while (*osendp) { while (*osendp) {
if (!isspace (*osendp)) if (!isspace ((unsigned char)*osendp))
slen = osendp - opstrp + 1; slen = osendp - opstrp + 1;
osendp++; osendp++;
} }
@ -328,7 +328,7 @@ int main(int argc, char **argv)
strcpy (tmp, opstrp); strcpy (tmp, opstrp);
strcat (tmp, " "); strcat (tmp, " ");
p = tmp; p = tmp;
while (!isspace(*p++)); while (!isspace((unsigned char)*p++));
*p = 0; *p = 0;
printf("/* %s */\n", tmp); printf("/* %s */\n", tmp);
printf("{0x%04X,%2d,{", bitpattern, n_variable); printf("{0x%04X,%2d,{", bitpattern, n_variable);